From 72605c589f02d1160dcfdc776986c5f7475a0ffe Mon Sep 17 00:00:00 2001
From: Patrick <thekabal@gmail.com>
Date: Wed, 15 Mar 2017 00:46:00 -0600
Subject: [PATCH] Strict type and fixes for variables with bad type handling

---
 navcomp.php | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/navcomp.php b/navcomp.php
index 43540d33b..b8c922447 100644
--- a/navcomp.php
+++ b/navcomp.php
@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types = 1);
 // The Kabal Invasion - A web-based 4X space game
 // Copyright © 2014 The Kabal Invasion development team, Ron Harwood, and the BNT development team
 //
@@ -38,19 +38,27 @@
 
 // Detect if this variable exists, and filter it. Returns false if anything wasn't right.
 $state = null;
-$state = (int) filter_input(INPUT_POST, 'state', FILTER_SANITIZE_NUMBER_INT);
-if (mb_strlen(trim($state)) === 0)
+$state = (string) filter_input(INPUT_POST, 'state', FILTER_SANITIZE_NUMBER_INT);
+if (($state === null) || (mb_strlen(trim($state)) === 0))
 {
     $state = false;
 }
+else
+{
+    $state = (int) $state;
+}
 
 // Detect if this variable exists, and filter it. Returns false if anything wasn't right.
 $stop_sector = null;
-$stop_sector = (int) filter_input(INPUT_POST, 'stop_sector', FILTER_SANITIZE_NUMBER_INT);
-if (mb_strlen(trim($stop_sector)) === 0)
+$stop_sector = (string) filter_input(INPUT_POST, 'stop_sector', FILTER_SANITIZE_NUMBER_INT);
+if (($stop_sector === null) || (mb_strlen(trim($stop_sector)) === 0))
 {
     $stop_sector = false;
 }
+else
+{
+    $state = (int) $state;
+}
 
 // Get playerinfo from database
 $sql = "SELECT * FROM ::prefix::ships WHERE email=:email LIMIT 1";