Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing and CI for image #3

Open
ketchoop opened this issue Feb 3, 2017 · 4 comments
Open

Testing and CI for image #3

ketchoop opened this issue Feb 3, 2017 · 4 comments
Labels
enhancement help wanted

Comments

@ketchoop
Copy link
Collaborator

ketchoop commented Feb 3, 2017

No description provided.

@ketchoop ketchoop assigned ketchoop and unassigned ketchoop Feb 3, 2017
@ptejada
Copy link

ptejada commented Jan 11, 2019

How can I assign this ticket to myself?

@corpsee corpsee assigned ptejada and unassigned ketchoop Jan 11, 2019
@corpsee
Copy link
Member

corpsee commented Jan 11, 2019

@ptejada Done.

@ptejada
Copy link

ptejada commented Jan 12, 2019 •
edited
Loading

I tried the installation in Windows with the Docker Toolbox v18.03. The installation went smoothly.

A few things that can be improved:

  1. Upgrade the docker composer file version to 3.
  2. Providing DB options is unnecessary. It should be assumed that if the consumer will be using the DB it will only be used for the PHP Censor software. If the consumer requires a specific DB they should provide it to the worker.
  3. By default, the DB container should be set up with a volume for storage. Otherwise, the database is lost when the container is disposed or rebuild.

Things I did not test:

  • Large test suites.
  • Multi worker and running build in parallel.

@corpsee
Copy link
Member

corpsee commented Jan 12, 2019

@ptejada Thank you for the massive testing! 👍 Could you create issues or PRs for all your points please?

@ptejada ptejada removed their assignment Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ptejada @corpsee @ketchoop