Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions thrown during the terminate() event dispatching should not cause the slave to crash #175

Open
acasademont opened this issue Dec 14, 2020 · 0 comments

Comments

@acasademont
Copy link
Contributor

During the Google outage today one function that sends some logs to Google PubSub in the Syfmony terminate() event failed, causing the whole slave to go down, even if the response had been correctly generated in the controller. The terminate event is used in Symfony to do some after-request processing, but it should not interfere with the response.

The easy fix would be to catch any exception thrown in the handling of the terminate event and log it.

The better fix would be to execute the terminate event after sending the response promise to the client, if not, a slow terminate event handler would cause the response to also be slowed down, in contrast of what happens in a normal PHP-FPM response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant