Fix potential OOB when checking for trailing spaces #17471
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
path_len
is zero, we must not accesspath
, let alone try to subtract-1
from it.Since
path
andpath_len
are supposed to come from azend_string
, this is not a security issue.Note that I'm not 100% sure whether the patch is correct, since
php_win32_check_trailing_space
apparently does not only check for trailing spaces, but also for leading spaces.