Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig macro for ad template #184

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Conversation

iMattPro
Copy link
Contributor

No description provided.

iMattPro added 6 commits July 7, 2024 17:47
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
Signed-off-by: Matt Friedman <[email protected]>
@iMattPro iMattPro requested a review from rxu November 18, 2024 00:57
@rxu
Copy link
Contributor

rxu commented Nov 18, 2024

This is probably unrelated to this PR, but this is what I see in administrator log (1 is a random ad name):

image

The macro itself works fine.

@iMattPro
Copy link
Contributor Author

When you disable the extension, the language key stored in the database can't be translated anymore. This should happened to any extensions.

@rxu
Copy link
Contributor

rxu commented Nov 18, 2024

That looks weird anyway :))
But whatever, the PR LGTM.

@iMattPro iMattPro merged commit 919fd8f into phpbb-extensions:master Nov 18, 2024
1 check passed
@iMattPro iMattPro deleted the updates branch November 18, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants