-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
continuous deployment ? #67
Comments
I do not see a benefit here. Due to that fact that github pages deploys automagically on push/merge to master. We are using a pullrequest based workflow. So every change would be tested twice and we had to add the complexity with another branch. |
In the case we merge tow or more PR in short time its possible they not tested with each PR. This way will secure this before we deploy. I now this case has not a big probably. I only want to say that this is possible. |
That's a true point, but travis also triggers a build after merge. So at least we would see a failing test, after merge. Maybe I'm the only one thinking like that... @BenjaminPaap @melwinm @glaubinix ? |
I currently do not see the need for that. There is currently not enough activity to justify such a step. It rarely happens that 2 PRs are ready to be merged at the same time. I think this should be discussed again should there ever be more and bigger changes coming. |
thanks for feedback, so I roll this up if we have a bigger PR frequency |
Sounds great then 👍 On Mon, Dec 16, 2013 at 10:44 AM, ClemensSahs [email protected]:
|
Travis CI allow us to update the master if tests are green.
anyone like this?
WORKFLOW:
publish
The text was updated successfully, but these errors were encountered: