Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative to pihole checkout #1388

Closed
PromoFaux opened this issue Jul 19, 2023 · 2 comments
Closed

Alternative to pihole checkout #1388

PromoFaux opened this issue Jul 19, 2023 · 2 comments
Labels

Comments

@PromoFaux
Copy link
Member

Install script is not run so the options are:

  • monkeypatch the functionality of pihole checkout into the container and customise the code
  • drop support for switching branches (This might be better, it's easy enough to build a new container on a custom branch)
@PromoFaux PromoFaux converted this from a draft issue Jul 19, 2023
@PromoFaux PromoFaux added the v6 label Jul 19, 2023
@DL6ER
Copy link
Member

DL6ER commented Jul 19, 2023

The later does indeed sound better and a lot less likely to break in unexpected ways

@PromoFaux
Copy link
Member Author

the build.sh script included in the repo makes this trivial

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pi-hole v6 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants