Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly fix slotscheck for Python 3.12 #899

Closed
dantownsend opened this issue Nov 3, 2023 · 0 comments · Fixed by #901
Closed

Properly fix slotscheck for Python 3.12 #899

dantownsend opened this issue Nov 3, 2023 · 0 comments · Fixed by #901
Labels
enhancement New feature or request testing

Comments

@dantownsend
Copy link
Member

When we upgraded to Python 3.12 slotscheck started failing because we inherit from Generic which no longer defines __slots__:

class Engine(t.Generic[TransactionClass], metaclass=ABCMeta):

In this PR #888 we stopped running slotscheck on Python 3.12 for now, as getting Python 3.12 support out was quite pressing.

piccolo/scripts/lint.sh

Lines 23 to 31 in 6cb005b

echo "Running slotscheck..."
# Currently doesn't work for Python 3.12 - so skipping until we can get a proper fix.
pythonVersion=$(python -c 'import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")')
if [ "$pythonVersion" == '3.12' ]
then
echo "Skipping Python 3.12 for now"
else
python -m slotscheck $MODULES
fi

Here's the corresponding issue on the slotscheck repo ariebovenberg/slotscheck#201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant