Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure ModelBuilder generates timezone aware values for Timestamptz #923

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

dantownsend
Copy link
Member

I realised that ModelBuilder wasn't generating timezone aware datetime values for Timestamptz columns. This can be important when testing.

@dantownsend dantownsend added the enhancement New feature or request label Jan 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (17e9448) 91.99% compared to head (62b542d) 91.98%.
Report is 2 commits behind head on master.

Files Patch % Lines
piccolo/apps/user/commands/list.py 71.42% 2 Missing ⚠️
piccolo/utils/printing.py 94.73% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%     
==========================================
  Files         107      108       +1     
  Lines        8165     8195      +30     
==========================================
+ Hits         7511     7538      +27     
- Misses        654      657       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend dantownsend merged commit 44940bb into master Jan 23, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants