Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Permission check in save hook does not work outside of admin context #839

Open
markus-moser opened this issue Feb 27, 2024 · 1 comment

Comments

@markus-moser
Copy link
Contributor

Expected behavior

It should be possible to rename data object/folders outside of the admin context when data hub workspaces are involved.

Actual behavior

This exception is triggered:

throw new \Exception('Permissions missing to save the configuration');

The reason is that isAllowed() does not work without a logged in Pimcore user or in the CLI context:

if (!$user) {

But the DataChangeListener tries to execute this save() method when the folder get's renamed outside of the admin context (for example in the portal engine)

Steps to reproduce

  1. Create a asset folder
  2. Create a data hub workspace config with this folder
  3. Create a test controller action outside of admin context and try to change the filename of the asset folder.
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant