Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Implement PQL as filter in graphql queries and deprecate current json-based filter implementation #891

Open
fashxp opened this issue Oct 2, 2024 · 1 comment

Comments

@fashxp
Copy link
Member

fashxp commented Oct 2, 2024

Feature description

to use PQL for defining filters instead of the current json syntax.
see also https://pimcore.com/docs/platform/Datahub/GraphQL/Query/Filtering

For simplicity, parallel filtering of PQL and json syntax is not necessary. Can be either or and throw an exception if both is set.

@mcop1
Copy link
Contributor

mcop1 commented Oct 23, 2024

Unfortunately not as easy as it seems at first glance.
Problem is, that we need to add generic-data-index as a dependency. Adding it as a suggestion wont be enough, because we need to know the types and interfaces to use them in use statements or in return / parameter types.
Technically we could use interface_exists checks and optional dependency to make it work, but that would result in a lot of duplicated code for the time being.
My suggestion would be to deprecate the current filter implementation and add the dependency to generic-data-index with the next major version. Or if there needs to be a transitional phase, then remove it in a later version, after the next major release.

@mcop1 mcop1 removed this from the 1.9.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants