Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: isGranted of PermissionEvent is ignored with NOT_ALLOWED_POLICY_NULL #909

Open
fmaerkl-sw opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels

Comments

@fmaerkl-sw
Copy link

Expected behavior

Elements where an event handler for PermissionEvents::PRE_CHECK sets isGranted to false should be returned as null or filtered out of the result of a GraphQL query when NOT_ALLOWED_POLICY_NULL is used.
Just like an exception is thrown when NOT_ALLOWED_POLICY_EXCEPTION is used in the same situation.

Actual behavior

The contents of isGranted are completely ignored. It can be easily seen here that the value of $event->isGranted() has no effect if PimcoreDataHubBundle::getNotAllowedPolicy() !== PimcoreDataHubBundle::NOT_ALLOWED_POLICY_EXCEPTION:

$event = new PermissionEvent($element, $type);
/** @var EventDispatcher $eventDispatcher */
$eventDispatcher = \Pimcore::getContainer()->get('event_dispatcher');
$eventDispatcher->dispatch($event, PermissionEvents::PRE_CHECK);
if (!$event->isGranted() && PimcoreDataHubBundle::getNotAllowedPolicy() === PimcoreDataHubBundle::NOT_ALLOWED_POLICY_EXCEPTION) {
throw new ClientSafeException('access for '. $element->getFullPath() . ' denied');
}
$isAllowed = self::isAllowed($element, $configuration, $type);
if (!$isAllowed && PimcoreDataHubBundle::getNotAllowedPolicy() === PimcoreDataHubBundle::NOT_ALLOWED_POLICY_EXCEPTION) {
$elementType = Service::getElementType($element);
throw new ClientSafeException($type . ' access for ' . $elementType . ' ' . $element->getFullPath() . ' denied');
}
return $isAllowed;

Steps to reproduce

Register a handler for PermissionEvent and set isGranted to false:

use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Pimcore\Bundle\DataHubBundle\Event\GraphQL\Model\PermissionEvent;
use Pimcore\Bundle\DataHubBundle\Event\GraphQL\PermissionEvents;

class GraphQlSubscriber implements EventSubscriberInterface
{
    public static function getSubscribedEvents(): array
    {
        return [
            PermissionEvents::PRE_CHECK => 'adaptPermissions'
        ];
    }

    public function adaptPermissions(PermissionEvent $event): void
    {
        $event->setIsGranted(false);
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants