Unify add/new and delete/remove actions #645

vin0401 · 2024-10-24T13:37:02Z

When do we use each? Add VS New
Add:

Rule - when inserting/ including/ choosing from existing data (fx when sharing a grid config with a user from the list)
Icon - magnifying glass in combination with a more descriptive icon (fx add a many to many relation = magnifying glass and folder). See here: https://www.figma.com/design/kTxowT29eCHwNh5NspDGGu/Pimcore-Components?node-id=7873-237917&t=jMfLSR7zjTmCjxH5-4

New:

Rule - when we are creating something that does not exist yet (fx new user in the system)
Icon - plus or plus in combination with a more descriptive icon (fx new image = plus and image). See here: https://www.figma.com/design/kTxowT29eCHwNh5NspDGGu/Pimcore-Components?node-id=7873-237918&t=jMfLSR7zjTmCjxH5-4

Exceptions:

add a column in the grid config (more natural word to use)
"Add & Edit" have the edit icon; "Edit" also has the edit icon. It is to indicate the user can modify and not only add.

When do we use each? Delete vs Remove/ Cancel/ Discard/ Clear
Delete:

Rule - when something gets erased from the system completely/ permanently (fx deleting an asset)
Icon - trash bin (icon only and with a label)

Remove/ Cancel/ Discard/ Clear:

Exceptions:

"x" icon is only used for closing (mostly on the modals). However "x" as a remove in the grid filters - not to confuse the filters with the config itself. Also in the batch editing following the same design.
Object Bricks Field has plus and minus as ways to add and remove bricks - the main icon is edit with the word edit.
Many-to-many - delete icon in tables is more common than remove and following the logic that we are not deleting the object itself but the relation, we are still following the ruleset.

Provide feedback