-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite config options to use dot notation #15
Comments
@kristofgazso I would like to work on this issue , can you please assign it to me? |
Will do as soon as I get back to my computer! Thanks for taking it up! |
I am about resolve it , if you dont mind can I submit pull request |
Of course, feel free to submit it |
Hi there I've submitted a pull request for the changes I made and I would really appreciate it if you could take some time to review it. Your feedback would be invaluable to help me improve the code and ensure that it's in line with the project's standards. Let me know if you have any questions or concerns. Thanks! |
@kristofgazso please review my pull request |
Currently all the options use names like lokiHost, lokiUsername, lokiPassword, signerPrivateKeys, utilityPrivateKey, maxSigners, etc.
Would be much cleaner to namespace them using dot notation for the configs where it makes sense, so something like loki.host, loki.username, loki.password, signer.privateKeys, signer.utilityKey, signer.maxSigners, etc.
The current config options are mostly written under
packages/cli/src
The text was updated successfully, but these errors were encountered: