Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite config options to use dot notation #15

Closed
kristofgazso opened this issue May 14, 2023 · 7 comments
Closed

Rewrite config options to use dot notation #15

kristofgazso opened this issue May 14, 2023 · 7 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@kristofgazso
Copy link
Contributor

Currently all the options use names like lokiHost, lokiUsername, lokiPassword, signerPrivateKeys, utilityPrivateKey, maxSigners, etc.

Would be much cleaner to namespace them using dot notation for the configs where it makes sense, so something like loki.host, loki.username, loki.password, signer.privateKeys, signer.utilityKey, signer.maxSigners, etc.

The current config options are mostly written under packages/cli/src

@kristofgazso kristofgazso added the good first issue Good for newcomers label May 14, 2023
@sumitshinde-84
Copy link

@kristofgazso I would like to work on this issue , can you please assign it to me?

@kristofgazso
Copy link
Contributor Author

Will do as soon as I get back to my computer!

Thanks for taking it up!

@sumitshinde-84
Copy link

I am about resolve it , if you dont mind can I submit pull request

@kristofgazso
Copy link
Contributor Author

Of course, feel free to submit it

@sumitshinde-84
Copy link

Hi there I've submitted a pull request for the changes I made and I would really appreciate it if you could take some time to review it. Your feedback would be invaluable to help me improve the code and ensure that it's in line with the project's standards. Let me know if you have any questions or concerns. Thanks!

@sumitshinde-84
Copy link

@kristofgazso please review my pull request

@mouseless0x
Copy link
Member

Closing this issue as the Alto configurations have been reworked/improved in #178 (adding namespaces to config flags) and #326 (global config support in Alto)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants