Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Namespace config options using dot notation #16

Closed
wants to merge 1 commit into from

Conversation

sumitshinde-84
Copy link

@sumitshinde-84 sumitshinde-84 commented May 14, 2023

This pull request introduces a comprehensive update to the configuration options in the CLI package. With this update, all options have been namespaced using dot notation, making it much easier to manage and organize them. This change results in cleaner and more readable code, which will be especially beneficial as the number of configuration options continues to grow.

All configuration options, including those related to Loki and the signer, have been updated to use the dot notation format. This change also involved updating all references to these configuration options throughout the package.

The code has been thoroughly tested to ensure that the new configuration options are properly implemented and function as expected. The tests have been included in the pull request for review.

Overall, this update will make it much easier for developers to work with and maintain the configuration options in the CLI package, leading to more efficient and streamlined development processes.

closes #15

@kristofgazso
Copy link
Contributor

thanks, will take a look today!

@sumitshinde-84
Copy link
Author

thanks, will take a look today!

Great, thank you! Let me know if you have any questions or if there's anything else I can do to help.

@plusminushalf
Copy link
Contributor

Hey we have changed our environment variables recently, and this PR is not relevance for now. Thank you for your contributions though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite config options to use dot notation
3 participants