-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: add LoadBalancerClass support for TiDB service #5964
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5964 +/- ##
==========================================
+ Coverage 57.19% 63.14% +5.94%
==========================================
Files 259 263 +4
Lines 33233 45661 +12428
==========================================
+ Hits 19008 28833 +9825
- Misses 12291 14816 +2525
- Partials 1934 2012 +78
|
/run-all-tests |
/run-pull-e2e-kind-basic |
/run-pull-e2e-kind-across-kubernetes |
/cherry-pick release-1.6 |
@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.6 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cherry-pick release-1.5 |
@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-pull-e2e-kind-across-kubernetes |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liubog2008 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
closes #5543
What is changed and how does it work?
Code changes
Tests
.service.type: LoadBalancer
and.service.loadBalancerClass: service.k8s.aws/nlb
for TiDB in TidbCluster CRreplicas
of TiDB to+1
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.