Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: add LoadBalancerClass support for TiDB service #5964

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Dec 6, 2024

What problem does this PR solve?

closes #5543

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
    1. set .service.type: LoadBalancer and .service.loadBalancerClass: service.k8s.aws/nlb for TiDB in TidbCluster CR
    2. apply the TidbCluster CR and wait for the TidbCluster to be ready
    3. check an LB service is created
    4. check the log of tidb-controller-manager, no repeated error log as LoadBalancerClass error #5543
    5. update the replicas of TiDB to +1
    6. wait for the TidbCluster to be ready again
    7. check the log of tidb-controller-manager, no repeated error log as LoadBalancerClass error #5543
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot ti-chi-bot bot requested a review from howardlau1999 December 6, 2024 03:47
@ti-chi-bot ti-chi-bot bot added the size/M label Dec 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.14%. Comparing base (a16b2e8) to head (385fe44).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5964      +/-   ##
==========================================
+ Coverage   57.19%   63.14%   +5.94%     
==========================================
  Files         259      263       +4     
  Lines       33233    45661   +12428     
==========================================
+ Hits        19008    28833    +9825     
- Misses      12291    14816    +2525     
- Partials     1934     2012      +78     
Flag Coverage Δ
e2e 45.99% <0.00%> (?)
unittest 56.97% <50.00%> (-0.22%) ⬇️

@csuzhangxc
Copy link
Member Author

/run-all-tests

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-basic

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.6

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.6 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc
Copy link
Member Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.5 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@csuzhangxc
Copy link
Member Author

/run-pull-e2e-kind-across-kubernetes

Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liubog2008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-06 07:52:22.957179572 +0000 UTC m=+1400530.576834087: ☑️ agreed by liubog2008.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 6, 2024
@csuzhangxc csuzhangxc merged commit a5bce17 into pingcap:master Dec 6, 2024
12 of 13 checks passed
@csuzhangxc csuzhangxc deleted the svc-lbc branch December 6, 2024 10:30
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.6: #5965.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Dec 6, 2024
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.5: #5966.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoadBalancerClass error
4 participants