Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to newly maintained version of jmespath #226

Closed
wants to merge 2 commits into from
Closed

deps: update to newly maintained version of jmespath #226

wants to merge 2 commits into from

Conversation

BitForger
Copy link

closes #223

@jsumners here is an updated version of jmespath. I will maintain it until the jmespath project revives, if that happens.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners
Copy link
Member

jsumners commented Sep 6, 2021

I will maintain it until the jmespath project revives, if that happens.

Has there been any attempt to communicate with the original project?

@BitForger
Copy link
Author

I will maintain it until the jmespath project revives, if that happens.

Has there been any attempt to communicate with the original project?

Yeah there was an issue in jmespath/jmespath.site#65 where the author claimed to be coming back in 2020 but has since to be heard from again.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Sep 6, 2021

Pull Request Test Coverage Report for Build 1206011091

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1200500617: 0.0%
Covered Lines: 319
Relevant Lines: 319

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1206011091

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1200500617: 0.0%
Covered Lines: 319
Relevant Lines: 319

💛 - Coveralls

@jsumners
Copy link
Member

jsumners commented Sep 6, 2021

I want to think about this some more. I don't like the state of upstream, but I also don't know of any other actual equivalent. Right now I'm thinking either:

  1. Drop the feature completely.
  2. I start the fork in the Pino org and invite you to help maintain it.

@mcollina
Copy link
Member

mcollina commented Sep 6, 2021

Maybe dropping the feature is ok.

@jsumners
Copy link
Member

jsumners commented Sep 6, 2021

Let's do it. Less maintenance is better maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jmespath uses an old, vulnerable version of jQuery
4 participants