-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update to newly maintained version of jmespath #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Has there been any attempt to communicate with the original project? |
Yeah there was an issue in jmespath/jmespath.site#65 where the author claimed to be coming back in 2020 but has since to be heard from again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull Request Test Coverage Report for Build 1206011091
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 1206011091
💛 - Coveralls |
I want to think about this some more. I don't like the state of upstream, but I also don't know of any other actual equivalent. Right now I'm thinking either:
|
Maybe dropping the feature is ok. |
Let's do it. Less maintenance is better maintenance. |
closes #223
@jsumners here is an updated version of jmespath. I will maintain it until the jmespath project revives, if that happens.