Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why not push built stable images to hub.docker.com? #3242

Closed
fuhongwei041 opened this issue Aug 14, 2017 · 4 comments
Closed

why not push built stable images to hub.docker.com? #3242

fuhongwei041 opened this issue Aug 14, 2017 · 4 comments
Labels

Comments

@fuhongwei041
Copy link

Pinpoint is a large sale program. When I try to build it , I spent more than two hours. When I try to build docker images , I spent more than two weeks. it's so frustrating. So I simply think pinpoint is not a good project, haha. why not to improve it at end user perspective.

@emeroad
Copy link
Member

emeroad commented Aug 14, 2017

Unfortunately, we are not experts in the docker.
Also, the docker is not our core issue, and we do not have enough time.
We are waiting for your contribution.
Good luck~

@Xylus Xylus added the proposal label Aug 16, 2017
@minyk
Copy link

minyk commented Aug 18, 2017

@fuhongwei041 pinpoint uses mvn docker plugin, so mvn clean package docker:build -DskipTests command is just enough. If you want to change image name and/or tag, see my repo: https://github.com/minyk/docker-pinpoint#custom

@kk17
Copy link

kk17 commented Oct 11, 2017

@emeroad It doesn't take much time to push the images to hub.docker.com. I think it more convenience for user to have official public docker images. @minyk mvn docker plugin version is to old which cause error when building with docker for mac #218

@RoySRose
Copy link
Contributor

RoySRose commented May 16, 2018

@fuhongwei041 @kk17
Check out pinpoint docker support.
We've recently started to maintain docker images.
Please comment us if there is anything to improve in the docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants