Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_hyperparameters method for PopulationMCMC #1327

Closed
ben18785 opened this issue Mar 23, 2021 · 2 comments
Closed

Add set_hyperparameters method for PopulationMCMC #1327

ben18785 opened this issue Mar 23, 2021 · 2 comments
Assignees
Labels

Comments

@ben18785
Copy link
Collaborator

I think, to make things simple for running benchmarking / functional tests, we should:

  1. Add another argument to set_temperature_schedule that allows setting of a schedule on the log scale. But would adding another option to an set_hyperparameter_* method complicate Change set_hyperparameters to accept a dictionary and named arguments #1320 ?
  2. Allow only an integer to be passed to set the number of gradations
  3. Include the initial_phase_iterations and the eta parameters of the underlying adaptive covariance method as other hyperparameters (looking at adaptive covariance, however, initial_phase_iterations doesn't seem to be given as a hyperparameter, but perhaps it should be?)
@MichaelClerx
Copy link
Member

For now, I've only used set_temperature_schedule as is.

  1. I think point 1 is part of Set temperature schedule on population MCMC to be uniform on log scale #409 . So whoever does that can have a look at this?
  2. This is already possible
  3. This should probably be handled whenever we allow different internal methods. Have made a ticket for that here: Allow PopulationMCMC to use different internal methods #1382

@ben18785
Copy link
Collaborator Author

Thanks @MichaelClerx -- agree with all your comments here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants