Send gamepad and keyboard input to Runtime #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove RobotInputDatum, which marked protos Input objects with the source gamepad index, and just send the Input objects from renderer to main. I'm not sure how to communicate the index information to Runtime or if it's important at all. Omitting this may have introduced a bug but ts is happy for now, so...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves to remind the user that keyboard strokes are being sent to the robot.
Get inputs half of the way to the robot...
...and then the other half.
Might introduce a bug, but I'm not sure what to do with the indices before sending them to the robot. The protos Input object itself has no field to record the index -- is it just their order in the UserInput packet? This would also mean that input sources shouldn't be mixed, which I've also done. Testing is needed.