Further improvements to path matching #64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @alvarocavalcanti
What is the problem / feature ?
Trying to match the path
/v1/accounts/23
against a schema with the following paths throws an error.How did it get fixed / implemented ?
Changed the logic around picking from multiple matches to choose the longest api path. This doesn't actually fix #58 but it still improves the situation.
How can someone test / see it ?
Match the path
/v1/accounts/23
against a schema with the following paths and see that it matches the/subscriptions
one correctly.Here is a cute animal picture for your troubles...