Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Scripts Adding Policy #2

Open
Jipok opened this issue May 24, 2021 · 3 comments
Open

New Scripts Adding Policy #2

Jipok opened this issue May 24, 2021 · 3 comments

Comments

@Jipok
Copy link

Jipok commented May 24, 2021

Although I got the rights to add anything without approval, I don't like the idea of uploading everything here.
I ask everyone interested to express their opinion on:

  1. I have uploaded 6 scripts here, do you think they are suitable for this project?
  2. What about armageddon.py with little code and little meaning?
  3. Should I add multiple implementations of the same script? For example, there is a hookshot script (teleportation to a visible block). Its code is very bloated and overcomplicated, I would like to rewrite it. So is it worth rewriting or posting a version that everyone uses. Or both?
    The same goes for mines and rpg(rocket).
  4. Should I upload ported foreign scripts such as AHT here?
@feikname
Copy link
Member

feikname commented Jun 1, 2021

  1. I'm totally ok with adding new scripts, I think it's nice.
  2. Same as above
  3. I'm very in favor of rewriting scripts*
  4. I don't see any problem posting foreign scripts as long as credit is due and the script license allows it.
    If the license doesn't allow we should link it somewhere and/or keep a nonfree folder.

*Regarding rewriting scripts, I'd suggest the following scheme: (taking platform.py as example)

  1. the old platform.py should stay platform.py, with a comment on top noting this is old version and rewritten version is preferred
  2. the rewritten platform.py is now the platform-pique-rewritten.py

This way there is no ambiguity possible, and stuff that reference platform.py won't break

Although I got the rights to add anything without approval, I don't like the idea of uploading everything here.

Sending via PR is IMO preferred to imply commiting as this allows everyone to review and suggest changes.

If you were talking about polluting, an index in the README or maybe even in piqueserver docs could suffice.

@Jipok
Copy link
Author

Jipok commented Jun 1, 2021

Sending via PR is IMO preferred to imply commiting as this allows everyone to review and suggest changes.

It seemed to me that people have no time to do this.

@feikname
Copy link
Member

feikname commented Jun 2, 2021

It seemed to me that people have no time to do this.

That is true, forgot about that. It's ok by me you commiting here whenever you see fit then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants