Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app.kubernetes.io/name should not be the same #719

Open
maxpain opened this issue Oct 12, 2024 · 1 comment
Open

app.kubernetes.io/name should not be the same #719

maxpain opened this issue Oct 12, 2024 · 1 comment

Comments

@maxpain
Copy link

maxpain commented Oct 12, 2024

Hello.

Currently, all the pods in piraeus-datastore namespace have the same app.kubernetes.io/name=piraeus-datastore label, which is not ideal.

For example, it's used in Hubble UI as an identity for traffic flows.

Screenshot 2024-10-12 at 20 40 17
@WanzenBug
Copy link
Member

That is unfortunate. I guess we should have used app.kubernetes.io/part-of: piraeus-datastore instead.

However, because this label is included in the selectors, I'm hesitant to change it, as that would require a complete delete/recreate of the deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants