Add default-mask to sensitive flags #674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The dependency test that failed has nothing to do with the changes in this PR. |
@sneal please rebase your pr with main, i fixed the failing test |
This keeps sensitive values specified in the OM_ env vars from showing up in the help
sneal
force-pushed
the
obscure-sensitive-values
branch
from
c43f7ed
to
0845b7f
Compare
|
@yharish991 all good now, thanks! |
|
@sneal is this good to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps sensitive values specified in the OM_ env vars from showing up in the help.
Previously:
With this change: