Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use unix paths in AssetWatcher.ts #103

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

bryanwood
Copy link
Contributor

Ran into #93 where the watch command doesn't work. Converting the paths to unix style ones appears to fix the issue for windows.

Not sure if this is the right way to fix it or not and I'm not able to test this on macOS.

@tom-yaxley-ge
Copy link

This certainly solves the problem for me! Hoping this gets merged soon!

@Zyie Zyie changed the title Use unix paths in AssetWatcher.ts fix: Use unix paths in AssetWatcher.ts Nov 19, 2024
Copy link
Member

@Zyie Zyie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for taking a while to review but this looks good, thank you!

@Zyie Zyie merged commit 33ebe6f into pixijs:main Nov 19, 2024
4 checks passed
@Zyie Zyie linked an issue Nov 19, 2024 that may be closed by this pull request
@CyberDex
Copy link
Member

TY @bryanwood. Great job on this one ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch command not working
4 participants