Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semver alters calver #20

Open
jhheider opened this issue Jan 6, 2023 · 3 comments
Open

semver alters calver #20

jhheider opened this issue Jan 6, 2023 · 3 comments

Comments

@jhheider
Copy link
Contributor

jhheider commented Jan 6, 2023

https://github.com/teaxyz/pantry.core/actions/runs/3858752567/jobs/6577617605

2023.01.06 > 2023.1.6. This could be fine, since we have version.raw. I'm not sure keeping zero-padding wouldn't be a different bug, but this is documenting.
@jhheider jhheider mentioned this issue Jan 6, 2023
Merged
@mxcl
Copy link
Member

mxcl commented Jan 8, 2023

we could add a version.calver

@mxcl
Copy link
Member

mxcl commented Jan 8, 2023

Typically I have used version.raw in these scenarios. If that works keep doing that. Leaving open as even though not strictly a bug, it's something we should have more official support for because inevitably there will be a situation where .raw isn’t good enough.

@jhheider
Copy link
Contributor Author

jhheider commented Jan 8, 2023

Add to this, that some people probably calver without zero-padding, and I'm sure it's just a mess. Raw does work, which is hopefully the right solution.

@mxcl mxcl transferred this issue from pkgxdev/pkgx Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mxcl @jhheider