Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of PICA K10plus Avram scheme breaks build #475

Open
nichtich opened this issue May 27, 2024 · 3 comments
Open

Update of PICA K10plus Avram scheme breaks build #475

nichtich opened this issue May 27, 2024 · 3 comments
Labels
partner:vzg Feature request from VZG schema:PICA PICA3 and PICA+ related issues

Comments

@nichtich
Copy link
Collaborator

I tried to update the PICA K10plus Avram schema at https://github.com/pkiraly/qa-catalogue/tree/avram-k10plus-update

The Avram schema looks good but Maven build fails because of failing tests.

An update of a valid Avram Schema should never make the build fail, otherwise we cannot deploy automatic updates.

I think the reason is in tests relying in a specific version of the Avram schema. If test do so, they should only use schema versions located in src/test/ directories.

Maybe the Avram schema be should be moved from src/main/ to be only loaded at run-time, not at compile time.

@nichtich nichtich added bug schema:PICA PICA3 and PICA+ related issues partner:vzg Feature request from VZG labels May 27, 2024
@pkiraly
Copy link
Owner

pkiraly commented May 31, 2024

It is also worth considering introducing versioning of the schema.

@nichtich
Copy link
Collaborator Author

I'll try to not update PICA K10plus Avram schema but use configuration parameter to provide updated version at runtime.

@nichtich nichtich removed the bug label May 31, 2024
@pkiraly
Copy link
Owner

pkiraly commented Feb 14, 2025

  • The test should pick infos from the schema
  • The schema location should be configurable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partner:vzg Feature request from VZG schema:PICA PICA3 and PICA+ related issues
Projects
None yet
Development

No branches or pull requests

2 participants