Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode Regex and IntSeq into native JS runtime types #26

Open
jasongwartz opened this issue Mar 17, 2024 · 0 comments
Open

Decode Regex and IntSeq into native JS runtime types #26

jasongwartz opened this issue Mar 17, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jasongwartz
Copy link
Contributor

Pkl Regex and IntSeq types currently decode into objects which contain properties as passed by pkl server (eg. pattern for Regex). In both cases, we could decode into native runtime types.

Regex is straightforward, it can decode into new Regexp().

IntSeq could of course decode it into an array, or some other kind of iterable.
@jasongwartz jasongwartz added the good first issue Good for newcomers label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasongwartz