Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPS installs unsupported stages into user_group_stage table #10874

Closed
Vitaliy-1 opened this issue Feb 2, 2025 · 2 comments
Closed

OPS installs unsupported stages into user_group_stage table #10874

Vitaliy-1 opened this issue Feb 2, 2025 · 2 comments
Assignees
@Vitaliy-1 @pkp-dev-distribution
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone
3.5 Internal

Comments

@Vitaliy-1
Copy link
Collaborator

Describe the bug
During installation, OPS installed default roles and includes unsupported stages to define to which stages they have access. See: https://github.com/pkp/ops/blob/614e5363f17494437d4db003ef25715f7e814193/registry/userGroups.xml#L17-L23 and

pkp-lib/classes/userGroup/Repository.php

Line 516 in 2050567

'stageId' => $stageId,

This adds WORKFLOW_STAGE_ID_SUBMISSION and WORKFLOW_STAGE_ID_PRODUCTION but OPS has only the latter stage: https://github.com/pkp/ops/blob/614e5363f17494437d4db003ef25715f7e814193/classes/core/Application.php#L179

What application are you using?
OPS main branch
@Vitaliy-1 Vitaliy-1 added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Feb 2, 2025
@Vitaliy-1 Vitaliy-1 added this to the 3.5 Internal milestone Feb 2, 2025
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Feb 3, 2025
@Vitaliy-1
pkp/pkp-lib#10874 Remove submission stage from roles installation
33b9a8d
@Vitaliy-1
Copy link
Collaborator Author

Vitaliy-1 commented Feb 3, 2025 •
edited
Loading

OPS: pkp/ops#858
pkp-lib: #10883

tests for OJS: pkp/ojs#4641

Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Feb 4, 2025
@Vitaliy-1
pkp#10874 Omit WORKFLOW_STAGE_ID_SUBMISSION stage for OPS
6346362
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Feb 5, 2025
@Vitaliy-1
pkp/pkp-lib#10874 Remove submission stage ID from user_group_stage du…
32c3b50 
…ring migration
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Feb 5, 2025
@Vitaliy-1
pkp#10874 Omit WORKFLOW_STAGE_ID_SUBMISSION stage for OPS
7c14c71
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Feb 5, 2025
@Vitaliy-1
pkp/pkp-lib#10874 Remove submission stage from roles installation
44bdb8c
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Feb 5, 2025
@Vitaliy-1
pkp/pkp-lib#10874 Remove submission stage ID from user_group_stage du…
433ecf7 
…ring migration
Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Feb 5, 2025
@Vitaliy-1
pkp#10874 Omit WORKFLOW_STAGE_ID_SUBMISSION stage for OPS
7b53dd0
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Feb 5, 2025
@Vitaliy-1
pkp/pkp-lib#10874 Remove submission stage from roles installation
d8b437d
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Feb 5, 2025
@Vitaliy-1
pkp/pkp-lib#10874 Remove submission stage ID from user_group_stage du…
de036a2 
…ring migration
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Feb 6, 2025
@Vitaliy-1
pkp/pkp-lib#10874 Check if tests are failing because of viewport dime…
756a917 
…nsions
@Vitaliy-1
Copy link
Collaborator Author

Related issues: #7599 and #7783.
@asmecher, can you review this? Do you think it's ok to remove submission stage from OPS now?

Vitaliy-1 added a commit to Vitaliy-1/pkp-lib that referenced this issue Feb 11, 2025
@Vitaliy-1
pkp#10874 Omit WORKFLOW_STAGE_ID_SUBMISSION stage for OPS
ecf81ba
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Feb 11, 2025
@Vitaliy-1
pkp/pkp-lib#10874 Remove submission stage from roles installation
012e900
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Feb 11, 2025
@Vitaliy-1
pkp/pkp-lib#10874 Remove submission stage ID from user_group_stage du…
1228378 
…ring migration
Vitaliy-1 added a commit to Vitaliy-1/ops that referenced this issue Feb 11, 2025
@Vitaliy-1
pkp/pkp-lib#10874 Check if tests are failing because of viewport dime…
baa4f37 
…nsions
Vitaliy-1 added a commit that referenced this issue Feb 11, 2025
@Vitaliy-1
Merge pull request #10883 from Vitaliy-1/i10874_groups_stages
5d820d0 
#10874 Omit WORKFLOW_STAGE_ID_SUBMISSION stage for OPS
Vitaliy-1 added a commit to pkp/ops that referenced this issue Feb 11, 2025
@Vitaliy-1
Merge pull request #858 from Vitaliy-1/i10874_groups_stages
99f4cee 
pkp/pkp-lib#10874 Remove submission stage from roles installation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vitaliy-1 Vitaliy-1

@pkp-dev-distribution pkp-dev-distribution

Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Milestone
3.5 Internal
Development

No branches or pull requests
2 participants
@Vitaliy-1 @pkp-dev-distribution