Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultUpdateWebhook and Item do not use the ItemId schema for their item_id fields #59

Open
relsunkaev opened this issue Oct 20, 2021 · 1 comment

Comments

@relsunkaev
Copy link

The #/components/schemas/DefaultUpdateWebhook and #/components/schemas/Item are not using the #/components/schemas/ItemId schema for their respective item_id fields. Since I'm assuming the reason ItemId has a schema at all is to be able to modify what an ItemId looks like in one place this might be worth fixing.

@phoenixy1
Copy link
Contributor

phoenixy1 commented Nov 4, 2021

This is intentional for the second one -- we sometimes do this because it in different contexts the same field needs a different description and there isn't a good way to do that via a shared ref in OpenAPI (not that I was able to find, anyway). I agree that DefaultUpdateWebhook probably could use the ItemId schema, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants