We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails.logger
This is not a safe way to check if an app is a rails app: https://github.com/plaid/plaid-ruby/blob/master/lib/plaid/configuration.rb#L161
We are NOT a rails app, yet Rails is defined because we use one of Rails' spun-off gems: https://github.com/rails/rails-html-sanitizer/blob/master/lib/rails-html-sanitizer.rb#L6
Rails
We are not actually loading the rails gem that would define Rails.logger. In our system, Rails is just a module.
Ideally, the aforementioned line would get replaced as follows:
@logger = (defined?(Rails) && Rails.respond_to?(:logger)) ? Rails.logger : Logger.new(STDOUT)
The text was updated successfully, but these errors were encountered:
Hey @benhutton - we're working on a fix here and will update with the next minor version. Thanks for calling this out!
Sorry, something went wrong.
Hi @benhutton - Could you see if version 14.12.1 solves your rails checking problem? Thanks!
@vorpus yes it does. Thank you!
No branches or pull requests
This is not a safe way to check if an app is a rails app: https://github.com/plaid/plaid-ruby/blob/master/lib/plaid/configuration.rb#L161
We are NOT a rails app, yet
Rails
is defined because we use one of Rails' spun-off gems: https://github.com/rails/rails-html-sanitizer/blob/master/lib/rails-html-sanitizer.rb#L6We are not actually loading the rails gem that would define
Rails.logger
. In our system,Rails
is just a module.Ideally, the aforementioned line would get replaced as follows:
The text was updated successfully, but these errors were encountered: