fix action pipeline #6718
Merged
fix action pipeline #6718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonny-jeahyunchoi
requested review from
sonohoshi and
eugene-doobu
as code owners
|
@jonny-jeahyunchoi The versions of bundled Libplanet assemblies and Libplanet submodule vendored by Lib9c apparently do not match:
Leave a comment in this pull_request with the following command to let the bot upgrade bundled Libplanet assemblies:
|
ipdae
approved these changes
Jan 16, 2025
jonny-jeahyunchoi
merged commit c3fbe8c
into
feature/new-arena-service-poc
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action Pipeline 개선
이 PR은 Action Pipeline의 여러 부분을 개선하는 내용을 포함하고 있습니다. 주요 변경 사항은 다음과 같습니다:
비동기 처리 추가:
ProcessAction메서드에onTxIdReceived콜백을 추가하여, 트랜잭션 ID 수신 후 비동기적으로 처리할 수 있도록 개선했습니다. 이를 통해 아레나 서비스와의 통신이 더 원활해졌습니다.코드 정리: 불필요한 주석 및 코드 중복을 제거하여 가독성을 높였습니다. 특히,
EnqueueAction메서드의 시그니처를 변경하여, 추가적인 콜백을 받을 수 있도록 했습니다.에러 처리 개선: 아레나 서비스 요청 실패 시, 오류 로그를 남기고 메인 화면으로 돌아가는 로직을 추가하여 사용자 경험을 개선했습니다.