Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement Addresses.GetAccountAddress(currency) method #2887

Closed
wants to merge 1 commit into from
Closed

feat: implement Addresses.GetAccountAddress(currency) method #2887

wants to merge 1 commit into from

Conversation

boscohyun
Copy link
Member

SSIA

@boscohyun boscohyun requested review from a team October 14, 2024 05:32
@boscohyun boscohyun self-assigned this Oct 14, 2024
@boscohyun boscohyun force-pushed the feat/get-account-address-of-balance branch from 7c61b90 to 5023e92 Compare October 14, 2024 05:39
@boscohyun boscohyun changed the title feat: implement Addresses.GetAccountAddressOfBalance() method feat: implement Addresses.GetAccountAddress(currency) method Oct 14, 2024
moreal
moreal reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@moreal moreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the expected use case in Lib9c project for the new method?

@boscohyun
Copy link
Member Author

What is the expected use case in Lib9c project for the new method?

I was expecting it to be used by those using Lib9c, and thought it would be easier to simply provide the account address for the call.

@moreal
Copy link
Contributor

moreal commented Nov 20, 2024

I was expecting it to be used by those using Lib9c, and thought it would be easier to simply provide the account address for the call.

I understand your intention, but I was wondering who exactly will be using the API. In another thought, I think it should be provided by the "Libplanet" library. How about suggesting this to them?

@boscohyun
Copy link
Member Author

boscohyun commented Nov 20, 2024 •
edited
Loading

I think it should be provided by the "Libplanet" library. How about suggesting this to them?

I agree. Hmm.. I'll request this to libplanet.👍

@boscohyun
Copy link
Member Author

Replace with this issue:
planetarium/libplanet#3987

@boscohyun boscohyun closed this Nov 20, 2024
auto-merge was automatically disabled November 20, 2024 03:00

Pull request was closed

@boscohyun boscohyun deleted the feat/get-account-address-of-balance branch November 20, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moreal moreal moreal left review comments

Assignees

@boscohyun boscohyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boscohyun @moreal