Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Better error message when createForModel is passed a bad argument #13

Open
kfriars opened this issue Feb 20, 2024 · 0 comments
Open

[Feature]: Better error message when createForModel is passed a bad argument #13

kfriars opened this issue Feb 20, 2024 · 0 comments

Comments

@kfriars
Copy link
Collaborator

kfriars commented Feb 20, 2024

What happened?

It isn't absolutely obvious when a bad arg is passed to createForModel in a migration. We should hint to developers to check the method call in the migration in question.

How to reproduce the bug

Call createForModel with something like the desired table name, and it will error complaining the model does not implement the versioned and model contracts.

Package Version

0.0.3

PHP Version

8.2.0

Which operating systems does with happen with?

No response

Notes

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kfriars