From e80f5e7b8d09ad63c2ac6d27aa9f150b5f77165d Mon Sep 17 00:00:00 2001
From: "stainless-app[bot]"
 <142633134+stainless-app[bot]@users.noreply.github.com>
Date: Sat, 23 Nov 2024 03:16:16 +0000
Subject: [PATCH] chore(internal): fix compat model_dump method when warnings
 are passed (#66)

---
 src/honcho/_compat.py | 3 ++-
 tests/test_models.py  | 8 ++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/honcho/_compat.py b/src/honcho/_compat.py
index 4794129..df173f8 100644
--- a/src/honcho/_compat.py
+++ b/src/honcho/_compat.py
@@ -145,7 +145,8 @@ def model_dump(
             exclude=exclude,
             exclude_unset=exclude_unset,
             exclude_defaults=exclude_defaults,
-            warnings=warnings,
+            # warnings are not supported in Pydantic v1
+            warnings=warnings if PYDANTIC_V2 else True,
         )
     return cast(
         "dict[str, Any]",
diff --git a/tests/test_models.py b/tests/test_models.py
index c8cc688..5e8bcf0 100644
--- a/tests/test_models.py
+++ b/tests/test_models.py
@@ -561,6 +561,14 @@ class Model(BaseModel):
             m.model_dump(warnings=False)
 
 
+def test_compat_method_no_error_for_warnings() -> None:
+    class Model(BaseModel):
+        foo: Optional[str]
+
+    m = Model(foo="hello")
+    assert isinstance(model_dump(m, warnings=False), dict)
+
+
 def test_to_json() -> None:
     class Model(BaseModel):
         foo: Optional[str] = Field(alias="FOO", default=None)