Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meraki is stuck loading an app if it can't find a platformatic.json file inside a service #602

Open
mcollina opened this issue Apr 16, 2024 · 6 comments · Fixed by #605
Open
Assignees

Comments

@mcollina
Copy link
Member

I think the service configuration should be loaded via the management API, not the file system.

@mcollina
Copy link
Member Author

@marcopiraccini marcopiraccini self-assigned this Apr 16, 2024
@marcopiraccini
Copy link
Contributor

marcopiraccini commented Apr 16, 2024

But the management API is available only if the app is running.
Why the platformtic.json was missing @mcollina ? Maybe we should raise an error in this case if it's something that can actually happen? (well, we show an error in any case, probably).
@tonysnowboardunderthebridge it's possible we are actually raising an error on the async call but the UI keeps waiting?

@mcollina
Copy link
Member Author

Why the platformtic.json was missing @mcollina ? Maybe we should raise an error in this case if it's something that can actually happen? (well, we show an error in any case, probably).

inside the services/ directory, we support platformatic.<kind>.json too (old format).

@tonysnowboardunderthebridge
Copy link
Contributor

Hi @marcopiraccini @mcollina

bug reproduced here with also the fix on ui

https://www.loom.com/share/f3df8e273584451cae32a769c9857c72

@tonysnowboardunderthebridge
Copy link
Contributor

Here the error that occurs when the application try to start

Schermata 2024-04-16 alle 17 26 05

@tonysnowboardunderthebridge
Copy link
Contributor

@marcopiraccini reopened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants