Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Godrays PR as a WebGL 2 only example #373

Open
FutureFireplace opened this issue Apr 29, 2022 · 5 comments
Open

Add Godrays PR as a WebGL 2 only example #373

FutureFireplace opened this issue Apr 29, 2022 · 5 comments

Comments

@FutureFireplace
Copy link

Hello, as the Godrays posteffect currently isn't available (anyway; as you write it needs to be compatible with WebGL 2.0), I want to hear if it can become so anyway in here as a github-source? (at least temporarely)

Even though I bought GodRays from Leonidas/Pirron-One, he did not reply with an answer a link from himself (he made available for our community some years ago).

Actually I would argue that it should be available in any case, as it (the WebGL 2.0-benchmark) is already above 80% penetration (https://www.khronos.org/blog/webgl-2-achieves-pervasive-support-from-all-major-web-browsers).

Testing of '1.0 or 2.0' should also be manageable according to: https://stackoverflow.com/questions/51428435/how-to-determine-webgl-and-glsl-version
Developers would then have the option of writing this to the user "This app's post effects is only supported by WebGL 2.0, which your device does comply to".

PS: I now there are Contributing Guidelines, but could not find a suit for this kind of issues.

@yaustar
Copy link
Collaborator

yaustar commented Apr 29, 2022

What do you mean by GitHub source?

@willeastcott willeastcott changed the title Godrays - Temporarely accessible in here as a github-source Godrays - Temporarily accessible in here as a GitHub-source Apr 29, 2022
@FutureFireplace
Copy link
Author

Remember that I downloaded the effect from Leonidas/Pirron-One as some sort of a package of files.
'Source' => just making that package available as zipped group of files (and 'in here/Github' >> as semiofficial access only, ... again with the 80%-premise of WebGL 2.0)

@yaustar
Copy link
Collaborator

yaustar commented Apr 30, 2022

Can you reference the source please? It makes it easier for anyone that wants to take on this issue

@FutureFireplace
Copy link
Author

ok, first of all this playcanvas/engine#3272

@yaustar yaustar changed the title Godrays - Temporarily accessible in here as a GitHub-source Add Godrays PR as a WebGL 2 only example May 4, 2022
@yaustar
Copy link
Collaborator

yaustar commented May 4, 2022

Ah, I see 🤔 We could make it a tutorial project example. With iOS 14 still being WebGL 1 only, we can't add it to the GitHub repo as the idea for PlayCanvas to have features and examples that work across a full range of devices and capabilities as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants