Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Feature Request - Disallow Uploading of pcconfig.json with API Key #24

Open
Christopher-Hayes opened this issue Jul 15, 2021 · 0 comments

Comments

@Christopher-Hayes
Copy link

By default, if you have a pcconfig.json in your target directory, playcanvas-sync will want to upload that file when you run pcsync pushAll. You can also keep your API key inside that config file. If that happens, the user will be making their API key available to the world when the project is deployed.

I do like the idea of keeping the pcconfig.json paired with a project for consistency across development environments. So, instead of disabling the uploading of pcconfig.json all together, it would be nice if playcanvas-sync had a special case where it checks pcconfig.json for the API key property before it uploads.

I embarrassingly made this mistake, and I know PlayCanvas has a lot of younger users. So, getting ahead of this might be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant