fix(edit): throw if user tries to edit a remote sub

plebbit · Mar 22, 2024 · 2b4c245 · 2b4c245
1 parent 95501eb
commit 2b4c245
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/cli/commands/subplebbit/edit.ts b/src/cli/commands/subplebbit/edit.ts
@@ -49,6 +49,8 @@ export default class Edit extends BaseCommand {
         const editOptions: SubplebbitEditOptions = DataObjectParser.transpose(lodash.omit(flags, ["plebbitRpcApiUrl"]))["_data"];
         log("Edit options parsed:", editOptions);
         const plebbit = await this._connectToPlebbitRpc(flags.plebbitRpcApiUrl.toString());
+        const localSubs = await plebbit.listSubplebbits();
+        if (!localSubs.includes(args.address)) this.error("Can't edit a remote subplebbit, make sure you're editing a local sub");
 
         const sub = <RpcLocalSubplebbit>await plebbit.createSubplebbit({ address: args.address });
         const mergedSubState = lodash.pick(sub.toJSONInternalRpc(), Object.keys(editOptions));

diff --git a/test/cli/edit.subplebbit.test.ts b/test/cli/edit.subplebbit.test.ts
@@ -23,6 +23,7 @@ describe("plebbit subplebbit edit", () => {
     before(() => {
         const plebbitInstanceFake = sandbox.fake.resolves({
             createSubplebbit: sandbox.fake.resolves({ edit: editFake, ...currentSubProps, toJSONInternalRpc: () => currentSubProps }),
+            listSubplebbits: sandbox.fake.resolves(["plebbit.eth"]),
             destroy: () => {}
         });
         //@ts-expect-error