Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log who saves a given schematic #3

Open
fyyv opened this issue Apr 18, 2022 · 2 comments
Open

Log who saves a given schematic #3

fyyv opened this issue Apr 18, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@fyyv
Copy link

fyyv commented Apr 18, 2022

Logging shows when users visit the endpoints for uploading or downloading schematics. However, when multiple users do this at the same time, it won't always be clear who the source of the most recent schematic is.

So, I suggest logging the source of schematics. There were two ways I had in mind. Please consider both of them:

  • If logging is enabled, output a message to the server logs, i.e. [<time> INFO]: [Plex HTTPD] user uploaded schematic Plex.schematic
  • Regardless of the state of logging, attach the uploader's username to the uploaded file in a database. In-game, if saving schematics is available, log the uploader's name from there too. I don't advise displaying the names publicly, but just for auditing purposes, I think the creator of any given schematic should be known to the database. On TF, players have been saving schematics of representations of very unsavory real-life actions, as well as setups for crashing or lagging players. Knowing who created the offending schematics would go a long way in discouraging their malicious use.
@Telesphoreo
Copy link
Member

I'll add logging to the console for uploading schematics.

@Telesphoreo Telesphoreo self-assigned this Apr 19, 2022
@Telesphoreo Telesphoreo added the enhancement New feature or request label Apr 19, 2022
@VideoGameSmash12
Copy link

VideoGameSmash12 commented Jan 26, 2024

This should be expanded upon by using IP addresses, UUIDs, and usernames. This would ensure that we know exactly who did it and where they uploaded the schematic from.

An example of a log message would be like
[<time> INFO]: [Plex HTTPD] <player name> (<uuid>) under <IP> uploaded schematic Plex.schematic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants