Skip to content
This repository has been archived by the owner on Jan 4, 2021. It is now read-only.

Source code readability #27

Open
mbalmer opened this issue Mar 21, 2016 · 4 comments
Open

Source code readability #27

mbalmer opened this issue Mar 21, 2016 · 4 comments

Comments

@mbalmer
Copy link
Member

mbalmer commented Mar 21, 2016

I find the current source code formatting a bit hard on the eyes, it is very dense, which imo makes the code harder to read and thus harder to maintain.

In the luapgsql (https://github.com/arcapos/luapgsql/blob/master/luapgsql.c) I use a convention called KNF ("Kernel Normal Form") that comes from the BSDs and which has the goal to make the code easily readable.

Would it make sense to adopt such a more readable formatting for PL/Lua as well? I am inclined to say yes, and I would volunteer to do the initial work, but only if other agree, of course.

@eugwne
Copy link
Member

eugwne commented Mar 21, 2016

👍

1 similar comment
@golgote
Copy link
Member

golgote commented Mar 21, 2016

👍

@mbalmer
Copy link
Member Author

mbalmer commented May 8, 2016

Ok, I will slowly start with this. Do you want to see pull requests or should I commit directly? I will more or less follow this style: http://cvsweb.netbsd.org/bsdweb.cgi/src/share/misc/style?rev=HEAD&content-type=text/x-cvsweb-markup, but I will take it as a collection of hints, not the law ;)

@eugwne
Copy link
Member

eugwne commented May 9, 2016

I'm comfortable with both options.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants