Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track down all implications of the __repr__ changes of Zope objects #2547

Closed
Rotonen opened this issue Oct 1, 2018 · 8 comments
Closed

Track down all implications of the __repr__ changes of Zope objects #2547

Rotonen opened this issue Oct 1, 2018 · 8 comments

Comments

@Rotonen
Copy link
Contributor

Rotonen commented Oct 1, 2018

There are recent changes in how Zope represents its objects. This breaks, at least, some of our doctests.

Entry vectors for understanding what this is about:

zopefoundation/zope.site#8
https://travis-ci.org/plone/plone.testing/builds/435575510

@icemac
Copy link

icemac commented Oct 16, 2018

Maybe we can add a __repr__ to OFS.SimpleItem which still contains the path in the ZODB.
See zopefoundation/persistent#96.

But maybe this is different from the actual problem you described here.

@thet
Copy link
Member

thet commented Oct 16, 2018

@icemac +1 for adding __repr__ to OFS.SimpleItem and actually what I suggested while discussing this issue in Halle :)
In the context of Zope, the path is a worthy info to be included in __repr__

@Rotonen
Copy link
Contributor Author

Rotonen commented Oct 16, 2018

@icemac see also zopefoundation/persistent#95

Will need to find time to figure out the cPersistent side. Help welcome.

Doctests are not the only issue there - also bad tooling, which consumes and reunsafes the ’bunches of bytes’ OIDs can be.

@icemac
Copy link

icemac commented Oct 18, 2018

@Rotonen I do not know enough C to be helpful to resolve zopefoundation/persistent#95. But I see your point and added the ticket to the Zope final issue list.

@jamadden
Copy link

zopefoundation/persistent#97 handles getting the type repr the same (and back to what it was) between C and Python; zopefoundation/persistent#98 handles formatting recognisable OIDs as hex ints.

pbauer added a commit to plone/buildout.coredev that referenced this issue Oct 20, 2018
@jamadden
Copy link

persistent 4.4.3 was released with those changes.

@gforcada
Copy link
Member

pbauer added a commit to plone/buildout.coredev that referenced this issue Oct 24, 2018
pbauer added a commit to plone/buildout.coredev that referenced this issue Oct 26, 2018
pbauer added a commit to plone/buildout.coredev that referenced this issue Oct 28, 2018
pbauer added a commit to plone/buildout.coredev that referenced this issue Oct 29, 2018
@pbauer
Copy link
Member

pbauer commented Nov 1, 2018

So far we use PathReprProvider to fix most __repr__ issues as explained in #2590 (comment).
The issue with _p_repr is continued in zopefoundation/persistent#101

@pbauer pbauer closed this as completed Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants