DIAZO_ALWAYS_CACHE_RULES not working as expected

[jjmurre]

Even when DIAZO_ALWAYS_CACHE_RULES has been set to 'false', the rules are cached.

The reason is that the check is done with:

if environ.get('DIAZO_ALWAYS_CACHE_RULES') and while environment values are just strings, this condition is always true.

[gforcada]

@jjmurre thanks for reporting the error and already nailing where the problem is!

Would you mind providing a pull request with a fix? If you still haven't done so, you would be required to sign the Contributors Agreement.

[jjmurre]

I tried to checkout plone.app.theming and build it with the provided buildout.cfg. Then run tests and add a test for the fix I want to provide.

That does not work (several error e.g. missing zc.recipe.cmmi, version conflicts etc.).

Is this approach (build stand-alone plone.app.theming) supposed to be working?

[ale-rt]

Anyway the behavior is consistent with the documentation that says "unless the environment variable DIAZO_ALWAYS_CACHE_RULES is set", without specifying anything about the value.

I am not afraid of changing the behavior in such a way that it checks for a "truish" value ('true', '1', 'yes', 'y', whatever), but if this happens we also have to update the docs :)

[thet]

I just stumpled into this problem, where DIAZO_ALWAYS_CACHE_RULES is set in buildout and cannot easily be unset in buildout config files unless overwriting the whole instance environment section.
For respecting the value of this variable, I'm 👍