Change name of devtools to choreographer #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
FYI the major test PR is here: https://github.com/geopozo/devtools_protocol/pull/15 |
gvwilson
reviewed
Oct 15, 2024
.github/workflows/test.yml
Outdated
| @@ -10,7 +10,7 @@ jobs: | |||
| - name: Install Dependencies | |||
| run: sudo apt-get update && sudo apt-get install chromium-browser xvfb | |||
| #- uses: ./.github/actions/ # it would be nice but it doesn't support timeout-minutes | |||
| - name: Install devtools | |||
| - name: Install Choreographer | |||
There was a problem hiding this comment.
why the upper-case 'C' in this test.yml file but lower-case 'c' elsewhere in this PR?
There was a problem hiding this comment.
2nd grade "titles should be capitalized!" habit
gvwilson
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change name of devtools to choreographer