Make default stderr sys.stderr, not passthrough #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Targeted windows before but now mac is acting up, so just do it everywhere
This allows to check for deletion even after python object is `del`ed
neyberson
reviewed
Nov 14, 2024
choreographer/browser.py
Outdated
| else: | ||
| stderr = debug_browser | ||
|
|
||
| # awful | ||
| if stderr and stderr != subprocess.PIPE and stderr != subprocess.STDOUT and stderr != subprocess.DEVNULL and not isinstance(stderr, int): |
There was a problem hiding this comment.
I think that this can be easy to read if you create some variables with some conditionals, like:
stuff_1= stderr != subprocess.PIPE
stuff_2 = stderr != subprocess.STDOUT
stuff_3 = stderr != subprocess.DEVNULL
if stderr and stuff_1 and stuff_2 and stuff_3 and not isinstance(stderr, int):
or
stuff = [subprocess.PIPE, subprocess.STDOUT, subprocess.DEVNULL]
if stderr and stderr not in stuff and not isinstance(stderr, int):
|
When this gets merged, we need to get up to 0.99.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default stderr to sys.stderr, not passthrough