\n";
@@ -1031,13 +1038,17 @@ public function getItems($rand, $data_ref, $plugin_order_orders_id, $numref, $ca
echo "function showDiscount$rand() {\n";
echo "$('#discount$rand').hide();";
echo "$('#viewaccept$rand').show();";
- Ajax::updateItemJsCode("viewdiscount$rand", Plugin::getWebDir('order') . "/ajax/inputnumber.php", [
- 'maxlength' => 15,
- 'size' => 8,
- 'name' => 'discount',
- 'class' => 'smalldecimal',
- 'data' => rawurlencode($discount)
- ], false);
+ Ajax::updateItemJsCode(
+ "viewdiscount$rand",
+ Plugin::getWebDir('order') . "/ajax/inputnumber.php",
+ [
+ 'maxlength' => 15,
+ 'size' => 8,
+ 'name' => 'discount',
+ 'class' => 'smalldecimal',
+ 'data' => rawurlencode($discount)
+ ]
+ );
echo "}";
echo "\n";
echo "
\n";
@@ -1133,7 +1144,7 @@ public function getItems($rand, $data_ref, $plugin_order_orders_id, $numref, $ca
while ($data = $DB->fetchArray($result)) {
$rand_line = mt_rand();
- Session::addToNavigateListItems($this->getType(), $data['IDD']);
+ Session::addToNavigateListItems($this->getType(), (int) $data['IDD']);
// Compute for detail_hideForm javascript function
$hideForm .= "$('#detail_pricetaxfree$rand_line').show();\n";
@@ -1182,31 +1193,35 @@ public function getItems($rand, $data_ref, $plugin_order_orders_id, $numref, $ca
echo "function showDetailPricetaxfree$rand_line() {\n";
echo "$('#detail_pricetaxfree$rand_line').hide();";
echo "$('#detail_viewaccept$global_rand').show();";
- Ajax::updateItemJsCode("detail_viewpricetaxfree$rand_line", Plugin::getWebDir('order') . "/ajax/inputnumber.php", [
- 'maxlength' => 15,
- 'size' => 8,
- 'name' => 'detail_price_taxfree[' . $data["IDD"] . ']',
- 'class' => 'decimal',
- 'data' => rawurlencode($data["price_taxfree"])
- ], false);
+ Ajax::updateItemJsCode(
+ "detail_viewpricetaxfree$rand_line",
+ Plugin::getWebDir('order') . "/ajax/inputnumber.php",
+ [
+ 'maxlength' => 15,
+ 'size' => 8,
+ 'name' => 'detail_price_taxfree[' . $data["IDD"] . ']',
+ 'class' => 'decimal',
+ 'data' => rawurlencode($data["price_taxfree"])
+ ]
+ );
echo "}";
echo "\n";
echo "
\n";
- echo Html::formatNumber($data["price_taxfree"]);
+ echo Html::formatNumber((float) $data["price_taxfree"]);
echo "
";
echo "
\n";
echo "
";
echo "";
} else {
- echo "
" . Html::formatNumber($data["price_taxfree"]) . " | ";
+ echo "
" . Html::formatNumber((float) $data["price_taxfree"]) . " | ";
}
/* taxe */
echo "
";
echo Dropdown::getDropdownName(
getTableForItemType("PluginOrderOrderTax"),
- $data["plugin_order_ordertaxes_id"]
+ (int) $data["plugin_order_ordertaxes_id"]
);
echo " | ";
/* reduction */
@@ -1219,29 +1234,33 @@ public function getItems($rand, $data_ref, $plugin_order_orders_id, $numref, $ca
echo "function showDetailDiscount$rand_line() {\n";
echo "$('#detail_discount$rand_line').hide();";
echo "$('#detail_viewaccept$global_rand').show();";
- Ajax::updateItemJsCode("detail_viewdiscount$rand_line", Plugin::getWebDir('order') . "/ajax/inputnumber.php", [
- 'maxlength' => 15,
- 'size' => 8,
- 'name' => 'detail_discount[' . $data["IDD"] . ']',
- 'class' => 'smalldecimal',
- 'data' => rawurlencode($data["discount"])
- ], false);
+ Ajax::updateItemJsCode(
+ "detail_viewdiscount$rand_line",
+ Plugin::getWebDir('order') . "/ajax/inputnumber.php",
+ [
+ 'maxlength' => 15,
+ 'size' => 8,
+ 'name' => 'detail_discount[' . $data["IDD"] . ']',
+ 'class' => 'smalldecimal',
+ 'data' => rawurlencode($data["discount"])
+ ]
+ );
echo "}";
echo "\n";
echo "
\n";
- echo Html::formatNumber($data["discount"]);
+ echo Html::formatNumber((float) $data["discount"]);
echo "
";
echo "
\n";
echo "
";
echo "";
} else {
- echo "
" . Html::formatNumber($data["discount"]) . " | ";
+ echo "
" . Html::formatNumber((float) $data["discount"]) . " | ";
}
/* price with reduction */
- echo "
" . Html::formatNumber($data["price_discounted"]) . " | ";
+ echo "
" . Html::formatNumber((float) $data["price_discounted"]) . " | ";
/* price ati */
- echo "
" . Html::formatNumber($data["price_ati"]) . " | ";
+ echo "
" . Html::formatNumber((float) $data["price_ati"]) . " | ";
/* status */
echo "
" . $reception->getReceptionStatus($data["IDD"]) .
" | ";
@@ -1367,7 +1386,7 @@ public function showPluginFromItems($itemtype, $ID)
$twig_option = [];
$order = new PluginOrderOrder();
$order->getFromDB($infos['id']);
- $twig_option['order_link'] = $order->getLink(PluginOrderOrder::canView());
+ $twig_option['order_link'] = $order->getLink();
$result = getAllDataFromTable(
self::getTable(),
@@ -1382,7 +1401,7 @@ public function showPluginFromItems($itemtype, $ID)
$reference = new PluginOrderReference();
$reference->getFromDB($link['plugin_order_references_id']);
if (Session::haveRight('plugin_order_reference', READ)) {
- $twig_option['reference_link'] = $reference->getLink(PluginOrderReference::canView());
+ $twig_option['reference_link'] = $reference->getLink();
}
$twig_option['delivery_date'] = Html::convDate($link["delivery_date"]);
}
@@ -1432,7 +1451,7 @@ public function showForm($ID, $options = [])
echo "
" . __("Order", "order") . ": | ";
echo "
";
- echo $order_order->getLink(true);
+ echo $order_order->getLink();
echo " | ";
echo "
" . __("Reference") . ": | ";
@@ -1575,12 +1594,12 @@ public function showBillsItems(PluginOrderOrder $order)
"' GROUP BY `plugin_order_bills_id`") as $item
) {
if (
- isset($item->fields['plugin_order_bills_id'])
- && $item->fields['plugin_order_bills_id']
+ isset($item['plugin_order_bills_id'])
+ && $item['plugin_order_bills_id']
) {
echo "
| ";
- if ($bill->can($item->fields['plugin_order_bills_id'], READ)) {
- echo " | " . $bill->getName() . " | ";
+ if ($bill->can($item['plugin_order_bills_id'], READ)) {
+ echo "" . $bill->getName() . " | ";
} else {
echo "" . $bill->getName() . " | ";
}
@@ -1723,7 +1742,7 @@ public function showBillsItemsDetail($data_ref, $result_ref, $canedit, $order, $
if (file_exists(GLPI_ROOT . "/src/" . $data["itemtype"] . "Type.php")) {
echo Dropdown::getDropdownName(
getTableForItemType($data["itemtype"] . "Type"),
- $data["types_id"]
+ (int) $data["types_id"]
);
}
echo "";
@@ -1732,14 +1751,14 @@ public function showBillsItemsDetail($data_ref, $result_ref, $canedit, $order, $
if (file_exists(GLPI_ROOT . "/src/" . $data["itemtype"] . "Model.php")) {
echo Dropdown::getDropdownName(
getTableForItemType($data["itemtype"] . "Model"),
- $data["models_id"]
+ (int) $data["models_id"]
);
}
$bill = new PluginOrderBill();
echo "";
if ($data["plugin_order_bills_id"] > 0) {
- if ($bill->can($data['plugin_order_bills_id'], READ)) {
- echo "" . $bill->getName(true) . "";
+ if ($bill->can((int) $data['plugin_order_bills_id'], READ)) {
+ echo "" . $bill->getName() . "";
} else {
echo $bill->getName();
}
@@ -1748,7 +1767,7 @@ public function showBillsItemsDetail($data_ref, $result_ref, $canedit, $order, $
echo " | ";
echo Dropdown::getDropdownName(
getTableForItemType('PluginOrderBillState'),
- $data['plugin_order_billstates_id']
+ (int) $data['plugin_order_billstates_id']
);
echo " | ";
echo "
";
@@ -1815,7 +1834,7 @@ public function updateQuantity($post)
);
$item = $DB->fetchArray($data);
- $this->getFromDB($item['id']);
+ $this->getFromDB((int) $item['id']);
$to_add = $post['quantity'] - $quantity;
$this->addDetails(
$this->fields['plugin_order_references_id'],
@@ -2115,9 +2134,10 @@ public static function countForItem(CommonDBTM $item)
public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
+ /** @var CommonDBTM $item */
if (in_array(get_class($item), PluginOrderOrder_Item::getClasses(true))) {
$orderlink = new PluginOrderLink();
- if (!$orderlink->isItemLinkedToOrder(get_class($item), $item->getID())) {
+ if (!$orderlink->isItemLinkedToOrder(get_class($item), $item->getField('id'))) {
return '';
}
@@ -2139,12 +2159,15 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
{
- if (get_class($item) == 'PluginOrderOrder') {
+ if ($item instanceof PluginOrderOrder) {
if (!$item->fields['is_template']) {
$order_item = new self();
$order_item->showItem($item->getID());
}
- } else if (in_array($item->getType(), PluginOrderOrder_Item::getClasses(true))) {
+ } else if (
+ is_subclass_of($item, CommonDBTM::class)
+ && in_array($item->getType(), PluginOrderOrder_Item::getClasses(true))
+ ) {
$order_item = new self();
$order_item->showPluginFromItems(get_class($item), $item->getField('id'));
}
diff --git a/inc/order_supplier.class.php b/inc/order_supplier.class.php
index 419a95b810..515f7338c3 100644
--- a/inc/order_supplier.class.php
+++ b/inc/order_supplier.class.php
@@ -455,12 +455,14 @@ public static function uninstall()
}
+ /**
+ * @return array|string
+ */
public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
switch (get_class($item)) {
case 'Supplier':
return [1 => __("Orders", "order")];
- break;
case 'PluginOrderOrder':
$config = PluginOrderConfig::getConfig();
if ($config->canUseSupplierInformations() && $item->fields['suppliers_id']) {
@@ -486,7 +488,7 @@ public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $
$order_supplier = new self();
if ($item->can($item->getID(), READ)) {
self::showOrderSupplierInfos($item->getID());
- $order_supplier->showForm("", ['plugin_order_orders_id' => $item->getID()]);
+ $order_supplier->showForm(-1, ['plugin_order_orders_id' => $item->getID()]);
}
break;
}
diff --git a/inc/preference.class.php b/inc/preference.class.php
index e1bed12bec..f8e9ca888f 100644
--- a/inc/preference.class.php
+++ b/inc/preference.class.php
@@ -146,7 +146,7 @@ public static function dropdownListFiles($name, $extension, $directory, $value =
*
* Check if at least one template exists
* @since 1.5.3
- * @return true if at least one template exists, false otherwise
+ * @return bool true if at least one template exists, false otherwise
*/
public static function atLeastOneTemplateExists()
{
@@ -159,7 +159,7 @@ public static function atLeastOneTemplateExists()
*
* Check if at least one signature exists
* @since 1.5.3
- * @return true if at least one signature exists, false otherwise
+ * @return bool true if at least one signature exists, false otherwise
*/
public static function atLeastOneSignatureExists()
{
@@ -284,7 +284,9 @@ public static function uninstall()
$DB->query("DROP TABLE IF EXISTS `" . self::getTable() . "`") or die($DB->error());
}
-
+ /**
+ * @return array|string
+ */
public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
if (get_class($item) == 'Preference') {
diff --git a/inc/profile.class.php b/inc/profile.class.php
index 0105f91e44..421440d694 100644
--- a/inc/profile.class.php
+++ b/inc/profile.class.php
@@ -153,11 +153,12 @@ public static function uninstall()
self::removeRightsFromSession();
}
-
+ /**
+ * @return array|string
+ */
public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
- $type = get_class($item);
- if ($type == 'Profile') {
+ if ($item instanceof Profile) {
if ($item->getField('id') && $item->getField('interface') != 'helpdesk') {
return [1 => __("Orders", "order")];
}
@@ -168,7 +169,7 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
{
- if ($item->getType() == 'Profile') {
+ if ($item instanceof Profile) {
$prof = new self();
self::addDefaultProfileInfos($item->getID(), [
'plugin_order_order' => 0, // All rights : CREATE + READ + ...
diff --git a/inc/reception.class.php b/inc/reception.class.php
index c214eeacf3..7764ef6be8 100644
--- a/inc/reception.class.php
+++ b/inc/reception.class.php
@@ -44,8 +44,6 @@ class PluginOrderReception extends CommonDBChild
public static $checkParentRights = self::DONT_CHECK_ITEM_RIGHTS;
- private $table;
-
public static function getTable($classname = null)
{
@@ -83,19 +81,21 @@ public function getFromDBByOrder($plugin_order_orders_id)
/** @var \DBmysql $DB */
global $DB;
- $query = "SELECT * FROM `" . $this->table . "`
- WHERE `plugin_order_orders_id` = '" . $plugin_order_orders_id . "' ";
- if ($result = $DB->query($query)) {
- if ($DB->numrows($result) != 1) {
- return false;
- }
- $this->fields = $DB->fetchAssoc($result);
+ $query = [
+ 'FROM' => self::getTable(),
+ 'WHERE' => ['plugin_order_orders_id' => $plugin_order_orders_id],
+ ];
+ $result = $DB->request($query);
+
+ foreach ($result as $fields) {
+ $this->fields = $fields;
if (is_array($this->fields) && count($this->fields)) {
return true;
} else {
return false;
}
}
+
return false;
}
@@ -276,7 +276,7 @@ public function showForm($ID, $options = [])
'name' => "plugin_order_bills_id",
'value' => $this->fields["plugin_order_bills_id"]
]);
- } else if (Session::haveRight("plugin_order_bill", UPDATE)) {
+ } else if (Session::haveRight("plugin_order_bill", READ)) {
echo Dropdown::getDropdownName(
"glpi_plugin_order_bills",
$this->fields["plugin_order_bills_id"]
@@ -489,7 +489,7 @@ public function showOrderReceptionItem($data_ref, $numref, $canedit, $reference,
foreach ($all_data as $data) {
$detailID = $data["IDD"];
- Session::addToNavigateListItems($this->getType(), $detailID);
+ Session::addToNavigateListItems($this->getType(), (int) $detailID);
echo "
";
$status = 1;
if ($typeRef != 'SoftwareLicense') {
@@ -501,7 +501,7 @@ public function showOrderReceptionItem($data_ref, $numref, $canedit, $reference,
if ($order_order->canDeliver() && $status) {
echo "| ";
- Html::showMassiveActionCheckBox(__CLASS__, $detailID);
+ Html::showMassiveActionCheckBox(__CLASS__, (int) $detailID);
echo " | ";
} else {
echo " | ";
@@ -528,13 +528,13 @@ public function showOrderReceptionItem($data_ref, $numref, $canedit, $reference,
}
echo "";
- echo "" . Dropdown::getDropdownName(getTableForItemType(Entity::class), $data["entities_id"]) . " | ";
+ echo "" . Dropdown::getDropdownName(getTableForItemType(Entity::class), (int) $data["entities_id"]) . " | ";
echo "" . Html::convDate($data["delivery_date"]) . " | ";
echo "" . $data["delivery_number"] . " | ";
echo "" .
Dropdown::getDropdownName(
"glpi_plugin_order_deliverystates",
- $data["plugin_order_deliverystates_id"]
+ (int) $data["plugin_order_deliverystates_id"]
) . " | ";
echo Html::hidden(
"id[$detailID]",
@@ -593,7 +593,7 @@ public function showOrderReceptionItem($data_ref, $numref, $canedit, $reference,
'plugin_order_orders_id' => $orders_id,
'plugin_order_references_id' => $references_id,
],
- false,
+ '',
false
) . "
}");
@@ -783,7 +783,7 @@ public function updateBulkReceptionStatus($params)
} else {
for ($i = 0; $i < $params['number_reception']; $i++) {
$this->receptionOneItem(
- $DB->result($result, $i, 0),
+ $DB->result($result, $i, 'id'),
$params['plugin_order_orders_id'],
$params["delivery_date"],
$params["delivery_number"],
@@ -1124,8 +1124,8 @@ public static function countForOrder(PluginOrderOrder $item)
public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
if (
- $item->getType() == 'PluginOrderOrder'
- && Session::haveRight('plugin_order_order', PluginOrderOrder::canView())
+ $item instanceof PluginOrderOrder
+ && PluginOrderOrder::canView()
&& $item->getState() > PluginOrderOrderState::WAITING_FOR_APPROVAL
) {
return self::createTabEntry(__("Item delivered", "order"), self::countForOrder($item));
@@ -1136,7 +1136,7 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
{
- if ($item->getType() == 'PluginOrderOrder') {
+ if ($item instanceof PluginOrderOrder) {
$reception = new self();
$reception->showOrderReception($item->getID());
}
diff --git a/inc/reference.class.php b/inc/reference.class.php
index a1bfc1eec6..5a9e529125 100644
--- a/inc/reference.class.php
+++ b/inc/reference.class.php
@@ -263,7 +263,6 @@ public static function getSpecificValueToDisplay($field, $values, array $options
case 'itemtype':
$item = new $values['itemtype']();
return $item->getTypeName();
- break;
}
return '';
}
@@ -381,7 +380,9 @@ public function defineTabs($options = [])
return $ong;
}
-
+ /**
+ * @return array|string
+ */
public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
if (get_class($item) == __CLASS__) {
@@ -393,7 +394,7 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
{
- if ($item->getType() == __CLASS__) {
+ if ($item instanceof self) {
$item->showOrders($item);
}
return true;
@@ -817,7 +818,7 @@ public function showOrders($ref)
echo "
";
echo "| ";
$order->getFromDB($data['plugin_order_orders_id']);
- echo $order->getLink(PluginOrderOrder::canView());
+ echo $order->getLink();
echo " | ";
echo "";
@@ -935,7 +936,7 @@ public static function showMassiveActionsSubForm(MassiveAction $ma)
_sx('button', 'Post') . "\" >";
return true;
}
- return "";
+ return false;
}
@@ -982,16 +983,17 @@ public static function processMassiveActionsForOneItemtype(MassiveAction $ma, Co
}
}
return;
- break;
case "copy_reference":
foreach ($ids as $id) {
- if ($item->getFromDB($id)) {
+ if (
+ $item instanceof self
+ && $item->getFromDB($id)
+ ) {
$item->copy($id);
}
$ma->itemDone($item->getType(), $id, MassiveAction::ACTION_OK);
}
return;
- break;
}
return;
}
diff --git a/inc/reference_supplier.class.php b/inc/reference_supplier.class.php
index 254226336f..0f93c27518 100644
--- a/inc/reference_supplier.class.php
+++ b/inc/reference_supplier.class.php
@@ -156,7 +156,9 @@ public function defineTabs($options = [])
return $ong;
}
-
+ /**
+ * @return array|string
+ */
public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
if (get_class($item) == __CLASS__) {
@@ -171,7 +173,7 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
{
$reference_supplier = new self();
- if ($item->getType() == 'PluginOrderReference') {
+ if ($item instanceof PluginOrderReference) {
if ($item->can($item->getID(), UPDATE)) {
$reference_supplier->showForm(0, ['plugin_order_references_id' => $item->getID()]);
}
@@ -208,7 +210,7 @@ public function showForm($ID, $options = [])
if ($ID > 0) {
$supplier = new Supplier();
$supplier->getFromDB($this->fields['suppliers_id']);
- echo $supplier->getLink(Session::haveRight('supplier', READ));
+ echo $supplier->getLink();
} else {
$suppliers = [];
$query = "SELECT `suppliers_id`
@@ -300,7 +302,7 @@ public function showReferenceManufacturers($ID)
echo Html::hidden('plugin_order_references_id', ['value' => $ID]);
while ($data = $DB->fetchArray($result)) {
- Session::addToNavigateListItems($this->getType(), $data['id']);
+ Session::addToNavigateListItems($this->getType(), (int) $data['id']);
echo Html::hidden("item[" . $data["id"] . "]", ['value' => $ID]);
echo " |
";
echo "| ";
@@ -315,12 +317,12 @@ public function showReferenceManufacturers($ID)
$link = Toolbox::getItemTypeFormURL($this->getType());
echo " | "
- . Dropdown::getDropdownName("glpi_suppliers", $data["suppliers_id"]) . " | ";
+ . Dropdown::getDropdownName("glpi_suppliers", (int) $data["suppliers_id"]) . "";
echo "";
echo $data["reference_code"];
echo " | ";
echo "";
- echo Html::formatNumber($data["price_taxfree"]);
+ echo Html::formatNumber((float) $data["price_taxfree"]);
echo " | ";
echo "
";
}
@@ -539,11 +541,11 @@ public static function showReferencesFromSupplier($ID)
while ($data = $DB->fetchArray($result)) {
echo "
";
echo "| ";
- echo Dropdown::getDropdownName("glpi_entities", $data["entities_id"]);
+ echo Dropdown::getDropdownName("glpi_entities", (int) $data["entities_id"]);
echo " | ";
echo "";
- echo Dropdown::getDropdownName("glpi_manufacturers", $data["manufacturers_id"]);
+ echo Dropdown::getDropdownName("glpi_manufacturers", (int) $data["manufacturers_id"]);
echo " | ";
echo "";
@@ -561,7 +563,7 @@ public static function showReferencesFromSupplier($ID)
echo " | ";
echo "";
- echo number_format($data["price_taxfree"], 2);
+ echo number_format((float) $data["price_taxfree"], 2);
echo " | ";
echo "
";
}
diff --git a/inc/surveysupplier.class.php b/inc/surveysupplier.class.php
index 6c403a894f..2b20a5453f 100644
--- a/inc/surveysupplier.class.php
+++ b/inc/surveysupplier.class.php
@@ -402,7 +402,7 @@ public static function showOrderSupplierSurvey($ID)
if ($DB->numrows($result) > 0) {
while ($data = $DB->fetchArray($result)) {
- Session::addToNavigateListItems(__CLASS__, $data['id']);
+ Session::addToNavigateListItems(__CLASS__, (int) $data['id']);
echo Html::hidden("item[" . $data["id"] . "]", ['value' => $ID]);
echo "
";
echo "| ";
@@ -416,7 +416,7 @@ public static function showOrderSupplierSurvey($ID)
echo " | ";
$link = Toolbox::getItemTypeFormURL(__CLASS__);
echo ""
- . Dropdown::getDropdownName("glpi_suppliers", $data["suppliers_id"]) . " | ";
+ . Dropdown::getDropdownName("glpi_suppliers", (int) $data["suppliers_id"]) . "";
echo "";
$total = $survey->getTotalNotation($ID);
echo $total . " / 5";
@@ -553,7 +553,6 @@ public static function uninstall()
$DB->query("DROP TABLE IF EXISTS `" . self::getTable() . "`") or die($DB->error());
}
-
public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
if ($item instanceof PluginOrderOrder) {
@@ -562,10 +561,10 @@ public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
$config->canUseSupplierSatisfaction()
&& $item->getState() == PluginOrderOrderState::DELIVERED
) {
- return [1 => __("Supplier quality", "order")];
+ return __("Supplier quality", "order");
}
}
- return [];
+ return '';
}
@@ -578,7 +577,7 @@ public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $
!$survey->checkIfSupplierSurveyExists($item->getID())
&& $item->can($item->getID(), UPDATE)
) {
- $survey->showForm("", ['plugin_order_orders_id' => $item->getID()]);
+ $survey->showForm(-1, ['plugin_order_orders_id' => $item->getID()]);
}
}
diff --git a/phpstan.neon b/phpstan.neon
index 139d323b4a..19bbd107b1 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -1,7 +1,7 @@
parameters:
parallel:
maximumNumberOfProcesses: 2
- level: 1
+ level: 5
bootstrapFiles:
- ../../inc/based_config.php
paths:
@@ -17,6 +17,7 @@ parameters:
- ../../stubs/glpi_constants.php
ignoreErrors:
- '#Call to deprecated method query\(\) of class DBmysql:#'
+ - '#Path in include_once\(\) ".*?/files/_plugins/order/generate/custom\.php" is not a file or it does not exist\.#'
excludePaths:
- 'inc/referenceinjection.class.php'
- 'inc/orderinjection.class.php'
|