Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle timeouts during ssh commands #35

Open
jprider63 opened this issue Mar 20, 2021 · 0 comments
Open

Properly handle timeouts during ssh commands #35

jprider63 opened this issue Mar 20, 2021 · 0 comments

Comments

@jprider63
Copy link
Member

This is from an old email, but I'm posting it here so it isn't lost.

Haskell doesn’t interrupt when running ffi code. This would cause issues when the runner would run a command over ssh (which is implemented via the ffi) and a timeout interrupt wouldn’t fire until the ssh command finished. This would occasionally cause issues where a remote command could hang forever (blocking a team) or the docker image wouldn’t be cleaned up properly. Manually restarting the runner and cleaning up old docker images would fix this temporarily. For the spring contest, I made updates to the ssh library to more gracefully handle interrupts. The issues only happened once during spring 2020, which is an improvement, but there’s still a bug to be tracked down. Rigorously testing this and tracking down this bug would be useful to minimize manual intervention during contests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant