Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming to plushu-git-apps #5

Closed
stuartpb opened this issue Aug 12, 2014 · 2 comments
Closed

Renaming to plushu-git-apps #5

stuartpb opened this issue Aug 12, 2014 · 2 comments

Comments

@stuartpb
Copy link
Member

Especially after plushu/plushu-git#5, this plugin is becoming increasingly responsible for all the components of managing apps' integration with Git, and if plushu/plushu-apps#4 goes through, they won't just be things that happen when receiving.

@stuartpb
Copy link
Member Author

Wait, no, plushu/plushu-apps#4 wouldn't have anything to do with this (it affects release and deployment plugins). Still, though, in refactoring plans, this plugin has repeatedly come within a whisker to taking on one kind of responsibility or another for apps beyond just receiving them. "plushu-git-apps" is starting to sound just plain reasonable.

As an example of how this plugin's scope is growing to be inaccurate, let's consider the possibility that I add another way to get apps via Git (probably via clone). If I could genericize that method and leave the implementation to plugins, I'd add it to this one rather than crafting another "plushu-git-something-app" plugin (since putting it as a feature of hooks makes it harmless if the equivalent method isn't installed).

Basically, the name change would reflect a more current view of how plugins are meant to be factored, where "plushu-git-receive-app" is more an artifact of the Dokku-based thought patterns in the original design (when the name was chosen to add specificity for other alternatives to the "receive" command plugin).

The name change will also make it dissimilar from git-receive-init and git-receive-warn-no-master, two verb-based plugin descriptions.

@stuartpb
Copy link
Member Author

Okay, you know what, let's do this: I'll rename this plugin when plushu-git-hooking gets renamed to plushu-git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant