Add -hook suffix to "githooks" hooks
#8
Comments
|
This would also mean a change to plushu-git-receive-app (soon to be plushu-git-apps) and plushu-git-receive-warn-no-master. |
Closed
stuartpb
added a commit
to plushu/plushu-git-apps
that referenced
this issue
Aug 14, 2014
stuartpb
added a commit
to plushu/plushu-git-receive-warn-no-master
that referenced
this issue
Aug 14, 2014
stuartpb
added a commit
that referenced
this issue
Aug 15, 2014
Because of the way plushook does buffering, we can't really hook the git command up to it. As such, we just use the hook for notification that the command is about to run instead (which is enough for the one use case the hook has right now). This *sort* of contradicts what I was thinking toward the end of #8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As described in #5, using the bare "git-" namespace for Git's hooks in the same namespace as any hooks Plushu would make around Git (and it looks like that's happening in the current plan to implement #5) is a name collision waiting to happen (we could semi-realistically have a
git-updatehook that gets called when the Git suite itself is updated, not to be confused with Git'supdatehook which would be atgit-update-hook).The text was updated successfully, but these errors were encountered: