Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rereleasing and redeploying without a build #2

Closed
stuartpb opened this issue Aug 19, 2014 · 0 comments
Closed

Rereleasing and redeploying without a build #2

stuartpb opened this issue Aug 19, 2014 · 0 comments

Comments

@stuartpb
Copy link
Member

Right now, plushu-config checks for build.iid before it plushooks release-app and deploy-app (plushu/plushu-config#1). However, plushu-domains doesn't check for release.iid before redeploying. I haven't checked, but I think that causes domains:add to fail when setting domains for an undeployed app.

I think these are the changes that need to happen:

  • domains needs to check for an app's existence before doing each of its commands (as config does).
  • release-env and start-web-deploy need to check for build.iid and release.iid, respectively, before taking action, since they may be called in a scenario where their prerequisite hasn't happened yet (the app has been created but not pushed and built).
  • config should not check for build.iid before rereleasing, as the relevance of whether the release and deploy will happen is up to the release and deploy plugins. It's possible that another app lifecycle ecosystem could be implemented that uses different criteria for how release and deployment proceed (even performing release/deployment steps in the absence of a build).
@stuartpb stuartpb changed the title Rereleasing and redeploying Rereleasing and redeploying without a build Aug 19, 2014
stuartpb added a commit to plushu/plushu-release-app-profile that referenced this issue Aug 20, 2014
stuartpb added a commit to plushu/plushu-deploy-app-local-container that referenced this issue Aug 20, 2014
stuartpb added a commit to plushu/plushu-config that referenced this issue Aug 20, 2014
stuartpb added a commit to plushu/plushu-domains that referenced this issue Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant